Log web socket errors #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 39 39
Lines 1415 1416 +1
=====================================
+ Hits 1415 1416 +1
Continue to review full report at Codecov.
|
eternal-flame-AD
approved these changes
Mar 6, 2019
GAS85
added a commit
to GAS85/website
that referenced
this pull request
Jun 5, 2020
This config causing Error as per gotify/server#139, additional config from gotify/server#23 needed. From: https://stackoverflow.com/questions/53939609/apache-websocket-connectionupgrade-replaced-by-keep-alive "Apache does not understand websockets in one sense (i.e. when it is talking to itself). As a result, you need to use mod_rewrite and set the protocol to ws:// in order to forward websockets upstream (it seems that no amount of setting headers will help you here)."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging like this: